Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: prepend locked ARIA to item button (fixes #182) #183

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update: prepend locked ARIA to item button (fixes #182) #183

merged 1 commit into from
Mar 19, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #182

Update

As per Vanilla issue #446, disabled locked buttons should have _globals._accessibility._ariaLabels.locked prepended to the button ARIA.

Testing

Set _lockType in course.json, for example "_lockType": "lockLast".

Locked menu items should have 'Locked' prepended to the button aria-label in place of the linkText 'View' text.
e.g. Locked. Adapt Assessment. Item 3 of 3.

When unlocked, button aria-label resumes linkText.
e.g. View Adapt Assessment. Item 3 of 3.

@kirsty-hames kirsty-hames self-assigned this Mar 13, 2024
@kirsty-hames kirsty-hames mentioned this pull request Mar 13, 2024
Open
joe-allen-89
joe-allen-89 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

swashbuck
swashbuck approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 8f6b3fb into master Mar 19, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/182 branch March 19, 2024 09:05
github-actions bot pushed a commit that referenced this pull request Mar 19, 2024
@semantic-release-bot
Chore(release): 6.6.0 [skip ci]
061361d 
# [6.6.0](v6.5.2...v6.6.0) (2024-03-19)

### Update

* Prepend locked ARIA to item button (#183) ([8f6b3fb](8f6b3fb)), closes [#183](#183)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#180) ([8b481c7](8b481c7)), closes [#180](#180)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepend locked ARIA to item button
5 participants
@kirsty-hames @swashbuck @cahirodoherty-learningpool @joe-allen-89 @oliverfoster