Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling dependency #61

Closed
danielghost opened this issue Jun 6, 2023 · 1 comment · Fixed by #62
Closed

Scrolling dependency #61

danielghost opened this issue Jun 6, 2023 · 1 comment · Fixed by #62
Assignees
@danielghost
Labels
released

Comments

@danielghost
Copy link
Contributor

Currently scrolling is intrinsic to bookmarking, meaning any content which doesn't scroll is not included in the location logic. Whilst Adapt is designed to use vertical scrolling, there are plugins which use a different navigation style.

Would it make sense to replace the scroll listener and add an inview listener for each added child view (where the _type matches the bookmarkLevel) instead? This means it doesn't matter how the content is navigated.
@danielghost danielghost self-assigned this Jun 6, 2023
@danielghost danielghost mentioned this issue Jun 7, 2023
Merged
danielghost added a commit that referenced this issue Jun 7, 2023
@danielghost
Update: removed scrolling dependency (fixes #61).
f5383c3
github-actions bot pushed a commit that referenced this issue Jun 12, 2023
@semantic-release-bot
Chore(release): 4.2.0 [skip ci]
06ce08a 
# [4.2.0](v4.1.3...v4.2.0) (2023-06-12)

### Update

* removed scrolling dependency ([24dc9c0](24dc9c0))
* removed scrolling dependency (fixes #61). ([f5383c3](f5383c3)), closes [#61](#61)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: removed scrolling dependency adaptlearning/adapt-contrib-bookmarking
1 participant
@danielghost