Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Derive original children after trickle config #189

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix: Derive original children after trickle config #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions js/adapt-assessmentArticleModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,18 @@ const AssessmentModel = {
},

init() {
// save original children
this._originalChildModels = this.getChildren().models;

Object.defineProperty(this, '_originalChildModels', {
get() {
// Perform this upon request as trickle button addition will change the children
if (this._originalChildModelsStore) return this._originalChildModelsStore;
// save original children
this._originalChildModelsStore = this.getChildren().models;
this._setAssessmentOwnershipOnChildrenModels();
return this._originalChildModelsStore;
}
});
this.setupCurrentQuestionComponents();

this._setAssessmentOwnershipOnChildrenModels();

// ensure the _questions attribute is set up (see https://github.com/adaptlearning/adapt_framework/issues/2971)
this._updateQuestionsState();
},
Expand Down Expand Up @@ -214,7 +219,7 @@ const AssessmentModel = {
const isOutOfBounds = (quizBankId > bankSplits.length);
if (isInvalidNumber) logging.warn(`Bank ID ${quizBankId} is not a valid number`);
if (isOutOfBounds) logging.warn(`Bank ID ${quizBankId} exceeds the number of available splits (${bankSplits.length})`);
});
});

const hasBankSplitsChanged = (bankSplits.length !== this._questionBanks?.length);
if (hasBankSplitsChanged) {
Expand Down
Loading