Fix: Logging instances of question bank misuse

.github/pull_request_template.md

@@ -8,7 +8,7 @@
 * A sentence describing each fix
 
 ### Update
-* A sentence describing each udpate
+* A sentence describing each update
 
 ### New
 * A sentence describing each new feature

js/adapt-assessmentArticleModel.js

@@ -198,6 +198,15 @@ const AssessmentModel = {
   _setupBanks() {
     const assessmentConfig = this.getConfig();
     const bankSplits = assessmentConfig._banks._split.split(',');
+
+    this.findDescendantModels('block')
+      .filter(block => block.get('_isAvailable') && block.findDescendantModels('question').length > 0)).forEach(block => {
+        const isInvalidNumber = (isNaN(block._quizBankId) || block._quizBankId < 1);
+        const isOutOfBounds = (block._quizBankId > bankSplits.length);
+        if (isInvalidNumber) logging.warn(`Bank ID ${block._quizBankId} is not a valid number`);
+        if (isOutOfBounds) logging.warn(`Bank ID ${block._quizBankId} exceeds the number of available splits (${bankSplits.length})`);
+    });
+
     const hasBankSplitsChanged = (bankSplits.length !== this._questionBanks?.length);
     if (hasBankSplitsChanged) {
       // Generate new question banks if the split has changed

js/adapt-assessmentQuestionBank.js

@@ -1,4 +1,5 @@
 import data from 'core/js/data';
+import logging from 'core/js/logging';
 
 class QuestionBank {
 
@@ -26,8 +27,13 @@ class QuestionBank {
   }
 
   getRandomQuestionBlocks() {
+    if (this._count > this.unusedQuestionBlocks.length) {
+      logging.warn(`Bank ID ${this._bankId}: Attempting to display ${this._count} question(s), but only ${this.unusedQuestionBlocks.length} available`);
+    }
+
     const questionBlocks = [];
     let i = 0;
+
     while (i++ < this._count) {
       const nextBlock = this.unusedQuestionBlocks.shift();
       questionBlocks.push(nextBlock);