Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/146 Allowed component level tracking ids #153

Merged
merged 3 commits into from
Mar 16, 2022
Merged

issue/146 Allowed component level tracking ids #153

merged 3 commits into from
Mar 16, 2022

Conversation

oliverfoster
Copy link
Member

fixes #146

Changes

  • Move from using block level _trackingId to level agnostic _trackingId

@oliverfoster oliverfoster self-assigned this Mar 2, 2022
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

lc-alexanderbenesch
lc-alexanderbenesch approved these changes Mar 7, 2022
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joe-allen-89
joe-allen-89 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with 5.19.0 with a mixture of _trackingID on components and blocks, trackings ids & relative offset being pulled through as expected.

@oliverfoster oliverfoster merged commit e6f3b9f into master Mar 16, 2022
@oliverfoster oliverfoster deleted the issue/146 branch March 16, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make _trackingId location agnostic
4 participants
@oliverfoster @cahirodoherty-learningpool @lc-alexanderbenesch @joe-allen-89