Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assessment overrides _canShowFeedback and _canShowModelAnswer even if not set #65

Closed
moloko opened this issue Dec 18, 2015 · 1 comment
Closed

assessment overrides _canShowFeedback and _canShowModelAnswer even if not set #65

moloko opened this issue Dec 18, 2015 · 1 comment
Assignees
@moloko
Labels
bug

Comments

@moloko
Copy link
Contributor

moloko commented Dec 18, 2015

If you leave these two properties out of the assessment article config, assessmentArticleModel still attempts to set them on every question, which has the effect of forcing _canShowFeedback to false and _canShowModelAnswer to true.

The behaviour should be the same as if you leave out _canShowMarking i.e. the setting for each question is used instead.
@moloko moloko changed the title assessment overrides '_canShowFeedback' and '_canShowModelAnswer' even if not set assessment overrides _canShowFeedback and _canShowModelAnswer even if not set Dec 18, 2015
@moloko moloko added the bug label Dec 18, 2015
@moloko moloko self-assigned this Dec 18, 2015
moloko added a commit that referenced this issue Dec 18, 2015
@moloko
Merge pull request #66 from adaptlearning/issue/#65
aa2b051 
fix for #65
@moloko
Copy link
Contributor Author

moloko commented Dec 18, 2015

fixed in v2.0.5

@moloko moloko closed this as completed Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moloko