Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Derive original children after trickle config #189

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix: Derive original children after trickle config #189

merged 1 commit into from
Nov 28, 2023

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Nov 21, 2023 •
edited
Loading

fixes #190

Fix

  • Capture children after spoor has restored and after trickle has added its buttons. This allows assessment to correctly and transparently manage its trickle configuration on reset.

Replaces

@oliverfoster oliverfoster self-assigned this Nov 21, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

marissa-champions
marissa-champions approved these changes Nov 27, 2023
View reviewed changes
Copy link

@marissa-champions marissa-champions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed it for me! Thanks

@oliverfoster oliverfoster merged commit f15d9e1 into master Nov 28, 2023
1 check passed
@oliverfoster oliverfoster deleted the issue/205a branch November 28, 2023 07:26
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
@semantic-release-bot
Chore(release): 5.1.10 [skip ci]
9076c0c 
## [5.1.10](v5.1.9...v5.1.10) (2023-11-28)

### Fix

* Derive original children after trickle config (#189) ([f15d9e1](f15d9e1)), closes [#189](#189)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.1.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@marissa-champions marissa-champions marissa-champions approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trickle issue with reset assessment
4 participants
@oliverfoster @cahirodoherty-learningpool @marissa-champions @joe-allen-89