Fix: Logging instances of question bank misuse

[cahirodoherty-learningpool]

Fixes #173

Fix

• Logging in place for when question banks are attempting to print more than available

Testing

1. Create a course with an assessment that uses question banks
2. Set a bank to display three but only have two blocks/components
3. Two questions should be printed
4. Console warning should be seen

[oliverfoster]

Should probably do one here for when a bank id is used in the blocks that is larger than bankSplits length?

adapt-contrib-assessment/js/adapt-assessmentArticleModel.js

Lines 200 to 202 in 4cc415d

	const bankSplits = assessmentConfig._banks._split.split(',');
	const hasBankSplitsChanged = (bankSplits.length !== this._questionBanks?.length);
	if (hasBankSplitsChanged) {

[cahirodoherty-learningpool]

Should probably do one here for when a bank id is used in the blocks that is larger than bankSplits length?

adapt-contrib-assessment/js/adapt-assessmentArticleModel.js

Lines 200 to 202 in 4cc415d

	const bankSplits = assessmentConfig._banks._split.split(',');
	const hasBankSplitsChanged = (bankSplits.length !== this._questionBanks?.length);
	if (hasBankSplitsChanged) {

I'm confused. This function is at the article level, but the Bank ID is per-block.

[oliverfoster]

Yea, you'll have to get the blocks and check their _quizBankId.

A QuestionBank instance is made for each questionBank id (which is the _banks._split index+1) and the QuestionBank instance becomes a set of blocks relating to that id. If someone configures a _banks._split of [2,2,2] and then assigns a _quizBankId of >3 || <1 || not an integer, the code won't warn, it should probably warn that the assigned id isn't valid, maybe? QuestionBank sets are only made for the indices represented by the length of the _banks._split array, so any non-valid id won't have a corresponding QuestionBank set.

I could see cases where it is desirable to set an id that isn't represented in the _banks._split length, but I'd assume that it would be because you'd want to exclude a finishing bank. This can be represented with a 0, such that [2,2,2,0] should work if you wanted to change the _banks._split but exclude the final bank in the course. That'll need checking obviously.

In general each valid _quizBankId should be represented in the _banks._split length and a warning should be generated otherwise.

[oliverfoster]

Does this now have your approval? @joe-allen-89

[github-actions]

🎉 This PR is included in version 5.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀