Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assessment restoration/completion #151

Closed
danielghost opened this issue Feb 7, 2022 · 1 comment · Fixed by #164
Closed

assessment restoration/completion #151

danielghost opened this issue Feb 7, 2022 · 1 comment · Fixed by #164
Assignees
Labels

Comments

@danielghost
Copy link
Contributor

Subject of the issue/enhancement/features

It is possible to return to an assessment which has rendered a results component without any feedback.

This seems to be because the assessment is not setting _isAssessmentComplete: true when all questions have been answered but trickle hasn't yet been clicked. Without clicking the trickle button, the block is not set to complete and therefore the assessment doesn't update the saved state.

Your environment

  • Adapt framework: 5.18.6

Steps to reproduce

  • Assessment must be set to "_isResetOnRevisit": false. Trickle needs to configured with the button enabled.
  • Complete all questions. Exit before clicking the trickle button on final question.
  • Relaunch and access the assessment. You can scroll down to the results, but no feedback is rendered as the relevant events have not been triggered.
@oliverfoster
Copy link
Member

oliverfoster commented Mar 30, 2022

This shouldn't matter as assessments are complete when all of the expected questions are complete, not the blocks:
https://github.com/adaptlearning/adapt-contrib-assessment/blob/master/js/adapt-assessmentArticleModel.js#L301-L308
Modified here 55410b4 and ca5db33

With the exception of when branching is enabled. There is a fix for that here https://github.com/adaptlearning/adapt-contrib-branching/pull/22/files and 55410b4

@oliverfoster oliverfoster self-assigned this Mar 30, 2022
RobertPeek added a commit to deltanet/adapt-contrib-assessment that referenced this issue Jun 7, 2022
Completion checking not firing for both blocks and questions (adaptlearning#151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants