Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update tests to meet new standards (fixes #149) #150

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Fix: Update tests to meet new standards (fixes #149) #150

merged 5 commits into from
Jun 18, 2024

Conversation

lemmyadams
Copy link
Contributor

Address #149

lemmyadams and others added 5 commits February 28, 2024 12:26
@lemmyadams
Added accordion e2e test
7ea3deb
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/accordion.cy.js
aadf59c 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
@lemmyadams
Corrected test
b3a22e5
@lemmyadams
Updated test
88e7716
@lemmyadams
Merge branch 'master' into issue/149
fb87bf2
@lemmyadams lemmyadams self-assigned this Jun 17, 2024
@lemmyadams lemmyadams changed the title Chore: Update tests to meet new standards (Issue/149) Fix: Update tests to meet new standards (Issue/149) Jun 17, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 changed the title Fix: Update tests to meet new standards (Issue/149) Fix: Update tests to meet new standards (fixes #149) Jun 18, 2024
joe-allen-89
joe-allen-89 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 2b9c1e4 into master Jun 18, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/149 branch June 18, 2024 14:38
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@semantic-release-bot
Chore(release): 7.6.2 [skip ci]
59820c0 
## [7.6.2](v7.6.1...v7.6.2) (2024-06-18)

### Fix

* Update tests to meet new standards (fixes #149) (#150) ([2b9c1e4](2b9c1e4)), closes [#149](#149) [#150](#150)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@lemmyadams lemmyadams

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemmyadams @cahirodoherty-learningpool @ethan-lp @joe-allen-89