Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SupportsRandomAccess property to IArchiveFactory #707

Closed
wants to merge 1 commit into from
Closed

Added SupportsRandomAccess property to IArchiveFactory #707

wants to merge 1 commit into from

Conversation

vpenades
Copy link
Contributor

@vpenades vpenades commented Nov 28, 2022

I've been using tgz files and I've realized they require being opened using the IReader interface to read them sequentially.

I thought it could be useful to embed that knowledge in the IArchiveFactory.

So both TAR and GZip factories have that property set to false.

This way, a program that wants to open any kind of archive, would know beforehand which is the preferred way of reading the archive and adjust accordingly.

Also added the "tgz" extension to tar factory.... I guess it would also require "tar.gz" but I'm hesitant to add extensions with extra dots.

@vpenades
Copy link
Contributor Author

Hmm... I think there's a better solution for this... closing!

@vpenades vpenades closed this Nov 28, 2022
@adamhathcock
Copy link
Owner

I like the idea of trying to tell people when using the API. Keep going!

@vpenades
Copy link
Contributor Author

vpenades commented Nov 28, 2022

opened an issue #708 to discuss before opening another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants