Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced IArchiveFactory #671

Merged
merged 7 commits into from
Sep 5, 2022
Merged

Introduced IArchiveFactory #671

merged 7 commits into from
Sep 5, 2022

Conversation

vpenades
Copy link
Contributor

As agreed in #670 , I've introduced the IArchiveFactory interface, with the bare minimum methods required to keep all the funcionality, and the factory implementations for each archive type.

Also, added the RegisterFactory method in ArchiveFactory and adjusted the Open method to use the registered factories instead of the fixed list.

remaining issues:

Not sure to which factory should I assign some extensions lik .LZ

In ArchiveFactory there's some more Open methods that still use the fixed list, I guess they should be redirected to the Open method that uses the factory collection.

@vpenades
Copy link
Contributor Author

I think the interface is pretty much ready for review

@adamhathcock adamhathcock merged commit f1d8fad into adamhathcock:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants