Implements "High Bit Depth Gamma Correction Algorithm for APA102/Dotstar LEDs" for the Adafruit Dotstar library. #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:
This is a code-style review. Right now the compilation tests pass. However, the way I've implemented this into the main object may not be exactly what the Adafruit team has in mind. So this PR at this time is to do a check-in and see if the way I've implemented is ok, or whether I should change it. If the style is ok, then I'll do final testing with a physical unit. Note that I've already done physical device testing with this change for the FastLED library PR and so i expect the testing to be straightforward and work on the first try.
Describe the scope of your change--i.e. what the change does and what parts
of the code were modified.
This implements the "High Bit Depth Gamma Correction Algorithm for APA102/Dotstar LEDs"
Describe any known limitations with your change.
This is portable c code implementation. However, I do add a gamma16 function which is 256*sizeof(uint16_t) units in prog memory.
I've added a new test .ino file. Please see onboard_hd.ino