Non blocking #26
Open
Non blocking #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrBrahma
approved these changes
Dec 23, 2018
SrBrahma
approved these changes
Dec 23, 2018
As per issue adafruit#14, Wire.requestFrom does not need to call Wire.endTransmission.
This change converts most methods to return their status (rather than void).
In this change, the isDataReady method is introduced as a way to poll on whether data is ready to be ready or not. On its first invocation, it requests that temperature be read and records the timestamp. On future invocations, it checks whether enough time has passed, and if so, will read the data. Upon reading temperature data, it requests pressure data and vice versa. When being run in this mode, calling getTemperature or getPressure will read the previously stored value (and perform any appropriate calculations on the data).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issue #24.
This adds a pattern for asking for changes in a polling fashion, removing the delays.
It includes a working example of how it can be used.
Note that this also depends upon changes #22 and #25.