Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add redirect service #1961

Merged
merged 3 commits into from
Nov 25, 2022
Merged

add redirect service #1961

merged 3 commits into from
Nov 25, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 6, 2021 •
edited
Loading

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Adds a rudimentary redirect HTTP service.

@robjtede robjtede added A-web project: actix-web B-semver-minor labels Feb 6, 2021
@robjtede robjtede marked this pull request as ready for review February 7, 2021 02:58
@robjtede robjtede requested review from a team February 7, 2021 18:32
robjtede
robjtede commented Feb 7, 2021
View reviewed changes
src/redirect.rs Outdated Show resolved Hide resolved
fakeshadow
fakeshadow approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@fakeshadow fakeshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robjtede robjtede added this to the actix-web post-v4 milestone Feb 11, 2021
@robjtede robjtede marked this pull request as draft February 11, 2021 21:20
Zageron
Zageron reviewed Jan 4, 2022
View reviewed changes
src/redirect.rs Outdated
Comment on lines 18 to 19
/// By default, the "308 Temporary Redirect" status is used when responding.
/// See [this MDN article](mdn-redirects) on why 308 is preferred over 301.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

308 is the permanent redirect.
Link goes to temporary redirect section, but 308 is listed in the permanent redirect section above it.

@robjtede
Copy link
Member Author

robjtede commented Jan 5, 2022

A preview of this is in actix-web-lab: https://docs.rs/actix-web-lab/0.2.0/actix_web_lab/struct.Redirect.html

@Zageron
Copy link

Zageron commented Jan 5, 2022

A preview of this is in actix-web-lab: https://docs.rs/actix-web-lab/0.2.0/actix_web_lab/struct.Redirect.html

fyi similar documentation issue over there too, and the MSDN link doesn't work. 😨
Loving the labs idea though.

@robjtede robjtede removed this from the actix-web post-v4 milestone Mar 1, 2022
@robjtede robjtede added this to the actix-web v4.3 milestone Sep 26, 2022
@robjtede robjtede marked this pull request as ready for review November 25, 2022 18:29
@robjtede robjtede requested a review from a team November 25, 2022 18:29
@robjtede robjtede force-pushed the feat/redirect branch 3 times, most recently from f678a73 to 71b6ac6 Compare November 25, 2022 18:32
@robjtede robjtede force-pushed the feat/redirect branch 3 times, most recently from 6914204 to 2ed65be Compare November 25, 2022 21:35
@robjtede robjtede merged commit 3c69d07 into master Nov 25, 2022
@robjtede robjtede deleted the feat/redirect branch November 25, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zageron Zageron Zageron left review comments

@fakeshadow fakeshadow fakeshadow approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
actix-web v4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@robjtede @Zageron @fakeshadow