Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples and aligned language within docs/checks/actions.md #1664

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

timburgan
Copy link
Contributor

@timburgan timburgan commented Feb 7, 2022

Added some practical examples to the docs/checks content.

This pages are linked to in the runner logs when the runner has connectivity issues.

I've added examples to the Actions to connectivity test, guiding users how to test this with curl, and aligned some formatting with the public GitHub documentation at https://docs.github.com. These updates align with the first troubleshooting steps that users will be requested to perform by GitHub Support.

In addition, for GitHub Enterprise Server, I included the common cause of these errors, that the default self-signed TLS certificate is being used rather than a trusted certificate. This will assist administrators with resolving this issue by uploading a trusted certificate to their appliance, or by enabling Let's Encrypt.

Using [hostname] within the GHES URL also aligns with best-practice from GitHub Support team.

@timburgan timburgan changed the title Added examples and aligned language Added examples and aligned language to docs/checks/actions.md Feb 7, 2022
@timburgan timburgan marked this pull request as ready for review February 7, 2022 07:07
@timburgan timburgan requested a review from a team as a code owner February 7, 2022 07:07
@timburgan timburgan changed the title Added examples and aligned language to docs/checks/actions.md Added examples and aligned language within docs/checks/actions.md Feb 7, 2022
@TingluoHuang TingluoHuang merged commit 2946801 into actions:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants