Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to acquire.pyi #198

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

melissawm
Copy link
Collaborator

This allows the documentation to be automatically added to the web pages at https://acquire-project.github.io/acquire-docs/api_reference/

These docstrings were initially added to the documentation manually by @dgmccart . I reworded some to avoid duplication and organize it but otherwise it is the same content.

This allows the documentation to be automatically added to the web pages at https://acquire-project.github.io/acquire-docs/api_reference/

Co-authored-by: dgmccart <92180364+dgmccart@users.noreply.github.com>
Follow-up to acquire-project/acquire-docs#78

Co-authored-by: dgmccart <92180364+dgmccart@users.noreply.github.com>
@melissawm
Copy link
Collaborator Author

This now includes the most recent changes from acquire-project/acquire-docs#78 and is ready for review. Thanks!

Copy link
Member

@aliddell aliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just one change is needed to make all the tests happy.

python/acquire/acquire.pyi Show resolved Hide resolved
Co-authored-by: Alan Liddell <alan.c.liddell@gmail.com>
Copy link
Member

@aliddell aliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aliddell aliddell merged commit 40d84e8 into acquire-project:main Jul 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants