Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The runtime should support empty AvailableData structs #137

Closed
aliddell opened this issue Dec 13, 2023 · 0 comments · Fixed by #138
Closed

The runtime should support empty AvailableData structs #137

aliddell opened this issue Dec 13, 2023 · 0 comments · Fixed by #138

Comments

@aliddell
Copy link
Member

See this comment:

We could consider adding support for an empty AvailableData, which might help clean up some of the Python examples and avoid the need for some of the checks in the with statements.

Users won't have to worry about whether or not the runtime returns None and can just proceed with an iterator, empty or not.
@aliddell aliddell mentioned this issue Dec 14, 2023
Merged
aliddell added a commit that referenced this issue Jan 5, 2024
@aliddell
Support empty AvailableData structs (#138)
9ac674f 
Closes #137.

- Change version string from 0.3.0 to 0.3.0-rc1.
- Updates acquire-core-libs and acquire-video-runtime submodules.
- Updates acquire-driver-zarr driver to v0.1.8 (bugfix release).
- Create an `AvailableData` struct on every call to
`runtime.get_available_data()`. It's no longer `Optional`, i.e., will
never be `None`.

🚨🚨 Potentially controversial decisions below 🚨🚨 
1. Remove the unused `_store` field from `VideoFrame` struct. This was
causing `test_setup()` to fail when I did not explicitly delete frames
returned by the video frame iterator.
2. As a consequence of (1), the `store` field of
`VideoFrameIteratorInner` struct was unused, so I removed this as well.
3. As a consequence of both (1) and (2), the only place
`RawAvailableData` is used is as a member `inner` of `AvailableData`, so
I made `AvailableData.inner` an `Option<RawAvailableData>`, where it was
previously an `Option<Arc<RawAvailableData>>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Image Acquisition Team Board
Archived in project
Milestone
No milestone
1 participant
@aliddell