Fix #9: Disallow superglobal variables #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisCarden
requested changes
Oct 11, 2021
There was a problem hiding this comment.
I agree, @danepowell: that's a breaking change. What if we do this to avoid an explosion of major versions for every little addition? We create a new AcquiaEdge ruleset where we collect breaking changes into batches for major releases. Then we just include them in the release notes whenever something's been added so people can opt in if they want to and ease into the next major release at their own pace. We would just need to add the new standard to README.md and document the policy.
|
Great idea. I also took the liberty of making the standard descriptions a little more consistent in the README. |
TravisCarden
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9
@TravisCarden do you think this warrants a major release? We should have a written policy on this. My feeling is that new standards likely to fail on existing projects should be considered backwards-incompatible.