Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns_miab.sh #5259

Closed
wants to merge 4 commits into from
Closed

Update dns_miab.sh #5259

wants to merge 4 commits into from

Conversation

lifeboy
Copy link
Contributor

@lifeboy lifeboy commented Aug 21, 2024

The MIAB API requires that the txtvlaue to a TXT record includes the "value=" and "ttl=" components as part of the TXT record when adding a new record.

The MIAB API requires that the txtvlaue to a TXT record includes the "value=" and "ttl=" components as part of the TXT record when adding a new record.
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@lifeboy lifeboy marked this pull request as ready for review August 22, 2024 12:41
@lifeboy
Copy link
Contributor Author

lifeboy commented Aug 22, 2024

The change is ready for merging. Anything else I need to do?

@lifeboy lifeboy marked this pull request as draft August 26, 2024 09:17
@lifeboy lifeboy closed this Aug 26, 2024
@lifeboy
Copy link
Contributor Author

lifeboy commented Aug 26, 2024

Should have first create PR to dev. Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant