-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server) Add new /invoke/:template endpoint implementation #746
Conversation
462f5dd
to
94fb2a2
Compare
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @mehmettokgoz, I've added some comments on your code.
Please also review the unit test coverage, it appears to have dropped a little. https://coveralls.io/builds/51999828/source?filename=packages%2Fcicero-server%2Fapp.js#L216
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one more comment on the eslint
version
@mehmettokgoz Your tests should pass once this PR has been merged. The failures are unrelated to your change. |
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
… invoke � Conflicts: � package-lock.json
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Signed-off-by: Mehmet Tokgöz <mehmet.tokgoz@hazelcast.com>
Changes
params.json
files forlatedeliveryandpenalty
template, used during testing.Flags
request.body
params
torequest
directly, comments are welcome.Demo
Sample request.body:
Response to sample request:
Author Checklist
--signoff
option of git commit.master
fromfork:branchname