Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(dateTime) parsing for DateTime without explicit format now consis… #379

Merged
merged 2 commits into from
Jul 1, 2019
Merged

bug(dateTime) parsing for DateTime without explicit format now consis… #379

merged 2 commits into from
Jul 1, 2019

Conversation

jeromesimeon
Copy link
Member

…tent with default format

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Issue #375

DateTime variables without format now are parsed exactly as if having the default YYYY/MM/DD format.

Changes

  • Remove DATE and DateTime rules from base parser
  • Switch parsing for DateTime bindings to use the format MM/DD/YYYY
  • Add test for NOFORMAT formatted dates

@jeromesimeon jeromesimeon requested a review from dselman July 1, 2019 19:46
dselman
dselman requested changes Jul 1, 2019
View reviewed changes
packages/cicero-core/test/data/formatted-dates-NOFORMAT/sample.txt Outdated
@@ -0,0 +1 @@
dateTimeProperty: 31/12/2019
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused, shouldn't this have to be 12/31/2019 ?

Copy link
Member Author

@jeromesimeon jeromesimeon Jul 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be. Bogged my test when I tried to make it fail. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now.

@jeromesimeon
bug(dateTime) parsing for DateTime without explicit format now consis…
123f73a 
…tent with default format

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon mentioned this pull request Jul 1, 2019
Closed
@coveralls
Copy link

coveralls commented Jul 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 95.34% when pulling e2b83d2 on jeromesimeon:js-375-date-without-format into e7dff8f on accordproject:master.

dselman
dselman approved these changes Jul 1, 2019
View reviewed changes
Copy link
Sponsor Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeromesimeon
chore(test) Remove dead code and improve test coverage
e2b83d2 
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon merged commit 3304f8b into accordproject:master Jul 1, 2019
@jeromesimeon jeromesimeon deleted the js-375-date-without-format branch July 2, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman dselman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromesimeon @coveralls @dselman