Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pangyp instead #15

Closed
wants to merge 1 commit into from
Closed

use pangyp instead #15

wants to merge 1 commit into from

Conversation

TakenPilot
Copy link

Using deasync on iojs currently fails because node-gyp has issue: nodejs/node-gyp#564

It's taking a long time for this issue to be fixed, so here is a branch that uses pangyp instead, so that iojs can also have deasync.

Also: actually prints any errors that occur, because otherwise they were being eaten, and it was very difficult to debug.

@dmabuada
Copy link

wonky spacing.

@nelsonpecora
Copy link

pretty simple. 👍

@dmabuada
Copy link

+1..but fix spacing. my 👀 , poor 👀

@TakenPilot
Copy link
Author

Not my spacing! I'm doing what's there. : )

@dmabuada
Copy link

shouldn't we fix what's there? haha.

or not. womp, womp.

@abbr
Copy link
Owner

abbr commented May 18, 2015

Have installed deasync successfully on several iojs platforms. See issue #13. Can you describe a case where your error is reproducible?

@TakenPilot
Copy link
Author

Sure, every time on CircleCI with iojs versions iojs-v1.2.0 and iojs-v1.3.0. Those are the versions supported on CircleCI by default: https://circleci.com/docs/environment#nodejs

The error produced is:

npm install
npm WARN optional dep failed, continuing fsevents@0.3.6


> deasync@0.0.10 install /home/ubuntu/byline/node_modules/multiplex-templates/node_modules/deasync
> node ./build.js

Build failed
npm WARN optional dep failed, continuing fsevents@0.3.6
npm ERR! Linux 3.14.28-031428-generic
npm ERR! argv "node" "/home/ubuntu/nvm/versions/io.js/v1.3.0/bin/npm" "install"
npm ERR! node v1.3.0
npm ERR! npm  v2.7.3
npm ERR! code ELIFECYCLE

npm ERR! deasync@0.0.10 install: `node ./build.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the deasync@0.0.10 install script 'node ./build.js'.
npm ERR! This is most likely a problem with the deasync package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls deasync
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/byline/npm-debug.log

npm install returned exit code 1

Action failed: npm install

When I edited the code to actually output the error:

npm install -g TakenPilot/deasync
|
> deasync@0.0.10 install /home/ubuntu/nvm/versions/io.js/v1.3.0/lib/node_modules/deasync
> node ./build.js

node-gyp rebuild 
gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: 404 status code downloading tarball
gyp ERR! stack     at Request.<anonymous> (/home/ubuntu/nvm/versions/io.js/v1.3.0/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:246:14)
gyp ERR! stack     at emitOne (events.js:82:20)
gyp ERR! stack     at Request.emit (events.js:166:7)
gyp ERR! stack     at Request.onRequestResponse (/home/ubuntu/nvm/versions/io.js/v1.3.0/lib/node_modules/npm/node_modules/request/request.js:1176:10)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! stack     at ClientRequest.emit (events.js:166:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:397:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
gyp ERR! stack     at Socket.socketOnData (_http_client.js:287:20)
gyp ERR! stack     at emitOne (events.js:77:13)
gyp ERR! System Linux 3.14.28-031428-generic
gyp ERR! command "node" "/home/ubuntu/nvm/versions/io.js/v1.3.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/ubuntu/nvm/versions/io.js/v1.3.0/lib/node_modules/deasync
gyp ERR! node -v v1.3.0
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok 
Some error occurred
Build failed: 1
npm ERR! Linux 3.14.28-031428-generic
npm ERR! argv "node" "/home/ubuntu/nvm/versions/io.js/v1.3.0/bin/npm" "install" "-g" "TakenPilot/deasync"
npm ERR! node v1.3.0
npm ERR! npm  v2.7.3
npm ERR! code ELIFECYCLE

npm ERR! deasync@0.0.10 install: `node ./build.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the deasync@0.0.10 install script 'node ./build.js'.
npm ERR! This is most likely a problem with the deasync package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./build.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls deasync
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/byline/npm-debug.log

npm install -g TakenPilot/deasync returned exit code 1

Action failed: npm install -g TakenPilot/deasync

Specifically: gyp ERR! stack Error: 404 status code downloading tarball

If you want, I could create a CircleCI circle.yml for this project so we could test this library on different versions.

@abbr
Copy link
Owner

abbr commented May 19, 2015

Thanks. I can reproduce your problem on circleci. But it's easy to specify a newer version of io.js (the one I verified working is 1.6) in your circle.yml. So I don't see the need to switch to pangyp, which I am not familiar enough to know all the catches.

@abbr abbr closed this May 19, 2015
@nelsonpecora
Copy link

Hmm, I'm getting the same issue locally as @TakenPilot was getting on CircleCI.

iojs version 2.0.2 (installed w/ nvm)
npm version 2.10.1
osx version 10.10.3

@abbr
Copy link
Owner

abbr commented May 23, 2015

Installed successfully on iojs@2.0.2, osx@10.8.5 via nvm.

@iamsebastian
Copy link

I also can not compile with node-gyp.
My local setyp:

Ubuntu@14.04 LTS
Linux 3.16.0-43-generic x86_64
iojs@2.3.4
npm@2.13.0
node-gyp@2.0.2
python@2.7.6

Installation with pangyp@2.2.1, like the above pull request described, runs fine.
So why not merge this pull request -- just, if all other platforms work well with pangyp used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants