Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Role connections & subscriptions #1487

Merged
merged 22 commits into from
Jul 9, 2024

Conversation

conorwastakenwastaken
Copy link
Contributor

@conorwastakenwastaken conorwastakenwastaken commented Feb 7, 2024

Adds role connections to Eris.

Hopefully I haven't missed anything. I've checked both the docs and the above PR in the API GH repo (that Bsian kindly linked for me) but honestly the pr diff was a mess and hard to read so I could've missed something.

Also adds role subscriptions to Eris.

I need to add the message content for the role subscription message that Discord sends, but I've no idea wtf the content is so any help would be appreciated!

Additions:

  • editRoleConnectionMetadataRecords() func in Client
  • getRoleConnectionMetadataRecords() func in Client
  • Message#roleSubscriptionData property
  • Documented role_connections_verification_url property under OAuthApplicationInfo
  • Obviously also added the necessary constants types, as well as the endpoint that the aforementioned functions use

@bsian03 bsian03 added the Discord label Feb 7, 2024
@conorwastakenwastaken conorwastakenwastaken changed the title feat: Role connections feat: Role connections & subscriptions Feb 10, 2024
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is everything related to role connections

lib/Client.js Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

role subscriptions

index.d.ts Show resolved Hide resolved
lib/structures/Message.js Outdated Show resolved Hide resolved
@bsian03 bsian03 merged commit 37f5e52 into abalabahaha:dev Jul 9, 2024
@conorwastakenwastaken conorwastakenwastaken deleted the roleconnections branch July 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants