Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(l1): avoid event topic rehashing #106

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

rkrasiuk
Copy link
Contributor

Avoid rehashing of event signatures in the chain watcher.

Used once_cell instead of existing lazy_static dep, because it's making its way to std. Happy to swap existing static metrics to once_cell as well in a follow-up PR, when this one is merged.

@ncitron
Copy link
Contributor

ncitron commented Apr 21, 2023

Good work! Can you just resolve the clippy issues?

@rkrasiuk
Copy link
Contributor Author

oops, didn't see those. fixed now

Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 9550c23 into a16z:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants