support v2.01 GRRCN files with v1.01 back compat #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejo
force-pushed
the
humanstate/GRRCN_v2.01_support
branch
from
ce0f6a6
to
807bf73
Compare
v2.01 was release in October 2019, v3.01 was release in April 2021 but no support for v3.01 is added here (yet) from the Amex "Raw Data - Global Reconciliation (GRRCN) Technical File Specification April 2021": "v1.01 of the GRRCN file format will be decommissioned as of October 31, 2021, any files sent as v1.01 will be migrated to v2.01 of the GRRCN file format. All customers using v1.01 of the file format will be automatically moved to v2.01 on October 31, 2021." so there is some urgency here as it is likely (at least from our testing) that v2.01 will break with the current implementation. the additional field here is FILLER in the TRANSACTION, SUBMISSION, and TAXRECORD lines. the code has been tweaked to use the VERSION value in the header and dynamically set the field_map depending on that, so it retains backwards compatibility. a test and example file has been added for v2.01 of the GRRCN file
leejo
force-pushed
the
humanstate/GRRCN_v2.01_support
branch
from
807bf73
to
5dc3c11
Compare
tomheady
approved these changes
Jul 23, 2021
|
Looks good, thanks for the patch! |
tomheady
pushed a commit
to tomheady/Finance-AMEX-Transaction
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.01 was release in October 2019, v3.01 was release in April 2021 but
no support for v3.01 is added here (yet)
from the Amex "Raw Data - Global Reconciliation (GRRCN) Technical File
Specification April 2021":
"v1.01 of the GRRCN file format will be decommissioned as of October 31,
2021, any files sent as v1.01 will be migrated to v2.01 of the GRRCN
file format. All customers using v1.01 of the file format will be
automatically moved to v2.01 on October 31, 2021." so there is some
urgency here as it is likely (at least from our testing) that v2.01 will
break with the current implementation.
the additional field here is FILLER in the TRANSACTION, SUBMISSION, and
TAXRECORD lines. the code has been tweaked to use the VERSION value in
the header and dynamically set the field_map depending on that, so it
retains backwards compatibility. a test and example file has been added
for v2.01 of the GRRCN file