Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.dev.varsにエンドポイントとesaのカテゴリー指定を追加 #20

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

Lailai0477
Copy link
Collaborator

close #13

@Lailai0477 Lailai0477 requested a review from Crow314 March 28, 2024 12:17
@Lailai0477
Copy link
Collaborator Author

実装時にCFworkersの環境変数に設定する必要がありそう

src/index.js Show resolved Hide resolved
Copy link
Contributor

@Crow314 Crow314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.dev.vars にある変数をworkflowでも読み込むようにしてほしさ

secrets: |
ESA_TOKEN
env:
ESA_TOKEN: ${{ secrets.ESA_TOKEN }}

sample.dev.vars Outdated Show resolved Hide resolved
@Lailai0477 Lailai0477 requested a review from Crow314 April 3, 2024 09:49
src/index.js Outdated Show resolved Hide resolved
Co-authored-by: Kazuma KIKUTA <32039188+Crow314@users.noreply.github.com>
@Lailai0477 Lailai0477 requested a review from Crow314 April 3, 2024 11:23
Copy link
Contributor

@Crow314 Crow314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
コメントへの対応もありがとうー

@Lailai0477 Lailai0477 merged commit b70d43c into develop Apr 3, 2024
3 checks passed
@Lailai0477 Lailai0477 deleted the issue/13 branch April 3, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dev.vars でのデータ取得元esaカテゴリー指定
3 participants