Update z-push-top.php #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max value for PIDs on 64-bit linux is 2^22 (approx 4 million) so 7 characters are needed to display the column reliably. Released under the GNU Affero General Public License (AGPL), version 3
matidau
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max value for PIDs on 64-bit linux is 2^22 (approx 4 million) so 7 characters are needed to display the column reliably.
Released under the GNU Affero General Public License (AGPL), version 3
What does this implement/fix? Explain your changes.
On a Rocky Linux 9 server, z-push-top.php is currently displaying PIDs as "724.." - this is not useful for isolating individual running syncs. As the max PID value on 64-bit linux systems can be 2^22 (approx 4 million) the PID column should be widened to display 7 chars.
...
Does this close any currently open issues?
No
...
Any relevant logs, error output, etc?
Before:
After:
...
Where has this been tested?
Server (please complete the following information):
OS: Rocky Linux 9
PHP Version: 8.1.14
and Version: [2.7.0]
OS: Rocky Linux 8
PHP Version: 7.4.33
and Version: [2.6.4]
Smartphone (please complete the following information):