Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/delete key and slot metadata for PIVSession #156

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

jensutbult
Copy link
Contributor

No description provided.

@jensutbult jensutbult marked this pull request as ready for review June 11, 2024 14:46
Copy link
Member

@AdamVe AdamVe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please review the typos I discovered.

/// @abstract Move key from one slot to another. The source slot must not be the attestation slot and the
/// destination slot must be empty. This method requires authentication with the management key.
/// @discussion This method requires authentication.
/// @param sourceSlot Slot to moe the key from.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo moe -> move

@@ -0,0 +1,26 @@
// Copyright 2018-2021 Yubico AB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 2024 instead of 2021

@@ -0,0 +1,30 @@
// Copyright 2018-2021 Yubico AB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 2024 instead of 2021

@@ -0,0 +1,42 @@
// Copyright 2018-2021 Yubico AB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@jensutbult jensutbult merged commit 5cbb858 into main Jun 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants