Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp-polyfill as dependency to react to fix IE11 bug #11608

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

IreneStr
Copy link
Contributor

@IreneStr IreneStr commented Nov 15, 2018

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the configuration wizard would not load in Internet Explorer 11 when Gutenberg was active.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Follow the steps from the issue.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #11597

@afercia
Copy link
Contributor

afercia commented Nov 15, 2018

Trying to recap some testing results:

The fix proposed for Gutenberg in WordPress/gutenberg#11916 makes the Configuration Wizard work correctly but doesn't completely solve our issue because I'm still getting an error for the Analysis WebWorker:

screenshot 143

I have no idea why but, as mentioned in the issue, the fact babel-polyfill is imported in js/src/wp-seo-analysis-worker.js might have some implications.

When applying this PR, the error is gone. Worth noting there are other warnings that come from Gutenberg, see WordPress/gutenberg#11918

Lastly, in the WP Dashboard I'm getting this error:

screenshot 138

which comes from createNSResolver() used in the yoast-components getFeed.js.

@IreneStr
Copy link
Contributor Author

The dashboard issue is a known issue: #11073

Let's merge this 😄

@IreneStr IreneStr merged commit 36e4cd2 into release/9.2 Nov 15, 2018
@IreneStr IreneStr deleted the 11597-fix-IE11-react-error branch November 15, 2018 16:56
@IreneStr IreneStr added this to the 9.2 milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants