Fix null on .show() android #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FrameLayout constructor fixed with context not activity. - getParent() returns null, the `android` prop on the `currentPage` is enough for *addView()* on the *ViewGroup* These changes work locally, still working on a minor issue with the map not rendering until the device screen goes to sleep and then when I wake the screen the map shows and the `.show().then()` executes.
|
Wrapping the |
|
Are you perhaps using Mapbox before |
|
Nope, navigating to a page in the app. Called in the loaded event on the page. |
|
Weird.. that would be so much easier when it's defined in XML ;) |
Closed
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 18, 2017
Fix null on .show() android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
androidprop on thecurrentPageis enough for addView() on the ViewGroupThese changes work locally, still working on a minor issue with the map not rendering until the device screen goes to sleep and then when I wake the screen the map shows and the
.show().then()executes.