Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN/EN/RU] Remove legacy timeout config #577

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

KobeArthurScofield
Copy link
Contributor

@KobeArthurScofield KobeArthurScofield commented Sep 15, 2024

以为继续在代码里面删史结果发现 dokodemo-door 和 HTTP 的 timeout 配置还挂在那里,还得先弃用一段时间再删,遂先在文档清理之。

移除内容:

  • dokodemo-door (inbound):应该退役的 timeout 设置项,顺便给英文文档补了示例;
  • http (inbound):应该退役的 timeout 设置项。

以上移除项以 userLevel (应先在 policy > levels 中先配置好 connIdle)替代。代码计划在 v25 开始前移除。

顺手再调整下大史记的排版并处理了一处手滑。

顺便给俄语文档放了个 wireguard inbound,但是得有缘人翻译。

@Fangliding
Copy link
Member

这些移除选项都是确认没用的吧

@KobeArthurScofield
Copy link
Contributor Author

是,都能替代
其实所有单独的 timeout 早就已经是标记了弃用,就是删到一半就断了

@Fangliding Fangliding merged commit 45353cd into XTLS:main Sep 15, 2024
2 checks passed
@KobeArthurScofield KobeArthurScofield deleted the deprecate-field-removal branch September 15, 2024 10:35
@mmmray
Copy link
Contributor

mmmray commented Sep 15, 2024

if there is an intent to deprecate something, i think it's best to use <detail> or HTML comment. otherwise somebody might think it's a mistake of the document and re-add it one year later

@KobeArthurScofield
Copy link
Contributor Author

if there is an intent to deprecate something, i think it's best to use <detail> or HTML comment. otherwise somebody might think it's a mistake of the document and re-add it one year later

Thank you, I think we can have it in the normal deprecation procedure ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants