re-enabling the savage hack #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
added a commit
that referenced
this pull request
Jun 22, 2015
re-enabling the savage hack, ref #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this patch re-enable the savage hack. The savage hack is is a very ugly workaround that replaces an older very ugly workaround. I want to add savage master support to qstat (see Unity-Technologies/qstat#6 and #110 ) but I have no time to do it right now so the easier is to keep this workaround to avoid regression.
Also, this patch fixes a bug (a list was not terminated); before this fix, the patch was usable only by lucky people.