Add support for dynamically changing image source properties (#139) #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-gokun
force-pushed
the
139-changing-mgl-image-source-coordinates-dynamically-causes-issues
branch
3 times, most recently
from
e187a06
to
608f4c5
Compare
Wykks
requested changes
Jul 3, 2019
projects/ngx-mapbox-gl/src/lib/source/image-source.component.ts
Outdated
Show resolved
Hide resolved
dmytro-gokun
force-pushed
the
139-changing-mgl-image-source-coordinates-dynamically-causes-issues
branch
from
608f4c5
to
55fd22a
Compare
Wykks
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #139
As you can see, it does not work super smoothly: we can see some flickering. I do not think that is something we can fix, as it seems to be inherent to mapbox. May be it looks better in 1.0.0 :)
UPD: I've removed flickering by specifying [paint]="{ 'raster-fade-duration': 0}" on the layer object, like the documentation suggests.