-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies to their latest versions. Angular => 8.0.0, mapbox-gl-js => 1.0.0 #154
Conversation
dmytro-gokun
commented
Jun 8, 2019
- rest of the dependencies
@Wykks Looks like Angular 8 requires newer node. Can we change that for CI? |
61c966a
to
6900884
Compare
@Wykks I've updated .travis.yml to use the proper node version. |
Will take a look this week-end (hopefully), but yep, looks good 👍 After that, we're gonna need to read through mapbox-gl changelog to support new stuff. |
@Wykks as far as I understand, this release does not have anything new codewise. It's all about their change in pricing model: https://blog.mapbox.com/new-pricing-46b7c26166e7 So, you need to make it clear in release notes for ngx-mapbox-gl as well. Maybe, some folks would like to stay on the old pricing model. However, I was not able to find any info on how long they plan to support it (the old pricing model). In any case, they're not likely to produce any updates to that old branch 0.XX, so 1.0.0 is a way to go, anyway |
Between v0.54.0 and v1.0.0 yes. But ngx-mapbox-gl was at 0.53.1. Maybe it's better to add v0.54.0 support in the v3.x version of ngx-mapbox-gl (despite the minor breaking changes in mapbox-gl). Edit: yep, will definitly do that 😄 |
@Wykks yeah, i think you are right (Y) Let me know if you need help with some particular issues. I cannot promise to do lot, but i can carve out 2-3 hrs a week to work on this library. Our app will benefit from it :) |
@dmytro-gokun If you can take a look at this issue, it would be great then 😄 |
@Wykks sure, please assign that to me and will try to have a look at it over the next week or two. not sure if right now i clearly understand the issue, but i will dive into it and ask appropriate questions, if any. As to this PR, i believe we may close it as it's now been decided to have separate releases for different Angular 8 & mapbox-gl-js update. So it's not relevant anymore. |
Cool! |