Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-3688 Update onResume type #250

Merged
merged 1 commit into from
May 1, 2024
Merged

FEA-3688 Update onResume type #250

merged 1 commit into from
May 1, 2024

Conversation

sorenthompson-wk
Copy link
Contributor

Motivation

https://dart.dev/tools/linter-rules/prefer_void_to_null

Changes

Change Future to Future

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • passing CI
      • passing consumer analysis
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@sorenthompson-wk sorenthompson-wk changed the title Update onResume type FEA-3688 Update onResume type May 1, 2024
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sorenthompson-wk sorenthompson-wk requested a review from a team May 1, 2024 16:53
Copy link

@lauracallahan-wk lauracallahan-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorenthompson-wk This LGTM, but could you fill in the QA section? Is CI passing sufficient here?

@sorenthompson-wk
Copy link
Contributor Author

@sorenthompson-wk This LGTM, but could you fill in the QA section? Is CI passing sufficient here?

I put it under "steps from the author"

Here is what I put:

  • passing CI
  • passing consumer analysis

I need to re-run consumer analysis. I accidentally pointed it at w_module master and not this branch

@sorenthompson-wk
Copy link
Contributor Author

Self QA +1

  • passing CI
  • passing consumer analysis

@sorenthompson-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit b850b84 into master May 1, 2024
5 checks passed
@rmconsole6-wk rmconsole6-wk deleted the update-type branch May 1, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants