Fix w_common v2 breaking changes #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
robbecker-wf
reviewed
Sep 7, 2022
| @@ -31,7 +31,7 @@ jobs: | |||
| if: always() && steps.install.outcome == 'success' | |||
|
|
|||
| - name: Analyze project source | |||
| run: dart run dart_dev analyze | |||
| run: dart analyze | |||
There was a problem hiding this comment.
switched to dart analyze since dart_dev still runs dartanalyzer and that fails on newer Dart versions
evanweible-wf
approved these changes
Sep 7, 2022
|
@Workiva/release-management-p |
|
QA+1 CI Passes |
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
rmconsole2-wf
deleted the
batch/fedx/fix_w_common_v2_breaking_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w_common has a number of deprecations that are removed in v2. This batch attempts to
fix as many of the breaking changes as possible to prepare to move to v2.
Breaking Changes: https://github.com/Workiva/w_common/blob/master/w_common/CHANGELOG.md#200
Created by Sourcegraph batch change
Workiva/fix_w_common_v2_breaking_changes.