Tools: Add RTLCSS step to theme build process #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
[Component] Theme
|
Note that I added a PR to wp-scripts to add RTLCSS there. I'm still going to merge this since I don't know how quickly that would make it through, but maybe we'll be able to remove it in a few weeks 🤞🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RTLCSS to the webpack build process (which requires a custom webpack.config.js, but we can inherit most of the configuration). This also fixes an issue with ratings on RTL sites.
Fixes #47, See WordPress/wporg-main-2022#124
Screenshots
How to test the changes in this Pull Request:
yarnyarn build:theme-rtl.cssfiles in the build output & build folder