Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Add "Log in" link to local nav #156

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Navigation: Add "Log in" link to local nav #156

merged 4 commits into from
Sep 10, 2024

Conversation

ryelle
Copy link
Collaborator

@ryelle ryelle commented Sep 9, 2024

This updates the Theme Directory to include the "Sign in" link in the local navigation across the site. The link only appears when you're logged out, once logged in, you can manage your account/login status in the admin bar.

I've already deactivated the "Logged Out Admin Bar" plugin on this site, so it won't show until you log in (and then it will show on all sites, see WordPress/wporg-mu-plugins@3b39f5f).

See WordPress/wporg-mu-plugins#647

Screenshots

Logged out Logged in
Screen Shot 2024-09-09 at 16 37 30 Screen Shot 2024-09-09 at 17 17 00

How to test the changes in this Pull Request:

  1. Be logged out
  2. There should be a "sign in" link
  3. Clicking it and signing in should redirect you back to the page you were just on
  4. The "sign in" link should not appear
  5. You should see the admin bar

Copy link

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works for me

@jasmussen
Copy link

Apologies for being late on this, can we change it from "Sign in" to "Log in" per this feedback?

Other than that, this is fantastic, thanks so much for working on this 🙏

@ryelle
Copy link
Collaborator Author

ryelle commented Sep 10, 2024

Text updated to "Log in"

Screenshot 2024-09-10 at 10 27 21 AM

@ryelle ryelle changed the title Navigation: Add "Sign in" link to local nav Navigation: Add "Log in" link to local nav Sep 10, 2024
@ndiego
Copy link
Member

ndiego commented Sep 10, 2024

Text updated to "Log in"

Looks great @ryelle

Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the code, but the functionality looks good.

@ryelle ryelle merged commit f52089c into trunk Sep 10, 2024
@ryelle ryelle deleted the add/sign-in-link branch September 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Blocks Custom blocks or block variations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants