Standardize left/right edge alignment #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
commented
Oct 21, 2021
| "left": "var(--wp--style--block-gap)", | ||
| "right": "var(--wp--style--block-gap)" | ||
| }, | ||
| "breakpoint": { |
There was a problem hiding this comment.
These were removed because they're no longer used.
If they were needed, though, I think the edge-spacing var this PR introduces is better than breakpoint-specific vars.
iandunn
changed the title
|
reminder: this will need to be rebased after #41 is merged |
This makes the styles more self-documenting, and more DRY.
iandunn
force-pushed
the
refine-alignment-37-minimal
branch
2 times, most recently
from
a7e75f8
to
964043b
Compare
This makes the spacing more consistent, and fixes several problems: * `alignfull` elements like `.post-navigation` should stretch to the viewport edge (but with internal padding). * Post titles should align with the post body. This is interconnected with related changes in the header/footer.
iandunn
force-pushed
the
refine-alignment-37-minimal
branch
from
964043b
to
71175f2
Compare
17 tasks
|
This seems problematic for the "People of WordPress" section: |
|
Can you elaborate on that? |
|
Sorry I was misunderstanding the implementation, its fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alignfulllayout elements like.post-navigationshould stretch to the viewport edge (but with internal padding). Compare to the the revised mockup in Refine padding/margin, override block gap #28 (comment)footer-archivestill needs some work, but that can be fixed in the pixel-perfect milestone.The page archive also needs some refinement (removing post-specific blocks, etc), but that can be done later.
Fixes #37
Interconnected with WordPress/wporg-mu-plugins#15