Add temporary fix for code syntax highlighting. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryelle if you have a chance today, can you review this PR? It's a temporary fix but an important one for the Blog, and we have a couple of articles set to be published this week that will need the fix so the code blocks appear correctly. Let me know if you have any questions/concerns 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Developer Blog uses the Code Syntax Block plugin to provide syntax highlighting to all Code blocks. This has worked great until recently, where new lines are replaced with
<br>elements in the code. The plugin does not parse these<br>elements as actual line breaks, thinking they are part of the code, which results in the following:As a temporary solution, this PR implements a filter for the Code block, replacing all
<br>with\n.