[CLI] Add WordPress constants using CLI arguments #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Enhancement
…li-constant-support
…li-constant-support
There was a problem hiding this comment.
This seems like a good change. A constant param isn't currently supported by the Query API, but it seems like an intuitive addition.
🤔 Eventually, maybe the Query API params could all have corresponding CLI arguments, ignoring any that don't make sense in a CLI context.
| @@ -108,6 +108,12 @@ async function run() { | |||
| type: 'boolean', | |||
| default: false, | |||
| }) | |||
| .option('constants', { | |||
There was a problem hiding this comment.
UX nit:
Could we make this singular like --constant and allow specifying multiple times?
| @@ -108,6 +108,12 @@ async function run() { | |||
| type: 'boolean', | |||
| default: false, | |||
| }) | |||
| .option('constants', { | |||
| describe: 'Define constants to be used in the Blueprint.', | |||
There was a problem hiding this comment.
Could we document the format of the argument, even if it seems intuitive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
I was testing #1789 and added support for defining constants to the CLI during development.
If feels like a useful feature, so I want to include it in the CLI.
Implementation details
A new
--constantsargument enables users to add WordPress constants to Playground.Testing Instructions (or ideally a Blueprint)
bun ./packages/playground/cli/src/cli.ts server --constants PLAYGROUND_FORCE_AUTO_LOGIN_ENABLED=true