Add documentation around the GPL license and implications for contribution #1776
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looping in @juanmaguitar for reviews |
sejas
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
It looks great to me.
I've executed nvm use && npm i && pm run dev:docs
And I was able to access http://localhost:3000/wordpress-playground/contributing
I got an error, but I don't think it's not related to his PR.
ERROR in ./src/typedoc-model.ts 2:0-30
Module not found: Error: Can't resolve './model.json' in '/Users/macbookpro/Documents/projects-m3.nosync/wordpress-playground/packages/docs/site/src'
I'm approving the PR. I would change the link to License, but happy to hear what other folks think about it.
Add local link Co-authored-by: Antonio Sejas <antonio@sejas.es>
adamziel
reviewed
Sep 24, 2024
adamziel
reviewed
Sep 24, 2024
|
Thank you for contributing @n8finch! I've added a few suggestions but it LGTM otherwise. |
Co-authored-by: Adam Zieliński <adam@adamziel.com>
Co-authored-by: Adam Zieliński <adam@adamziel.com>
|
@adamziel thanks for the review and suggestions, I've added them 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #504
Motivation for the change, related issues
Adding documentation around the GPL license and implications for contribution.
Implementation details
Just updated the readme.
Testing Instructions (or ideally a Blueprint)
Run the build and checkout the readme at
http://localhost:3000/wordpress-playground/contributing