Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move this repo under wordpress organization #11

Closed
adamziel opened this issue Sep 22, 2022 · 3 comments
Closed

Move this repo under wordpress organization #11

adamziel opened this issue Sep 22, 2022 · 3 comments

Comments

@adamziel
Copy link
Collaborator

Let's figure out how to do it. cc @gziolo

@gziolo
Copy link
Member

gziolo commented Sep 22, 2022

I'm sure there is a simple way to do it. @luisherranz might know best as he recently took part in moving https://github.com/WordPress/block-hydration-experiments from a personal account to WordPress org.

@luisherranz
Copy link
Member

@mtias did it for us.

@mtias
Copy link
Member

mtias commented Sep 26, 2022

Done

@mtias mtias closed this as completed Sep 26, 2022
eruizdechavez pushed a commit to eruizdechavez/wordpress-playground that referenced this issue Sep 20, 2023
…ordPress#71)

## Description

Solves WordPress#11

`wp-now` mounts mu-plugins like this:

```ts
    php.mount(
        path.join(getWpNowPath(), 'mu-plugins'),
        path.join(vfsDocumentRoot, 'wp-content', 'mu-plugins')
    );
```

The first path is the local HOST path, the second path is a VFS path.

On Mac and linux, they both use forward slashes.

On Windows, the first path can use backslashes, but the VFS path still
needs to use forward slashes.

Problem is: `path.join()` transforms all slashes to backslashes on
Windows, which makes the second path invalid like `\\var\\www\\html`.

This commit corrects that.

## Testing Instructions

Confirm wp-now and the VS code extension can both be started on Windows.
Confirm they didn't break on Mac or linux.

---------

Co-authored-by: sejas <antonio@sejas.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants