Skip to content

Commit

Permalink
Don't halt Playground boot when OPFS is not available
Browse files Browse the repository at this point in the history
  • Loading branch information
adamziel committed Oct 1, 2024
1 parent e62cce2 commit 4e0ef74
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 22 deletions.
19 changes: 19 additions & 0 deletions packages/playground/website/bin/version-switching-server.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { startVersionSwitchingServer } from '../playwright/version-switching-server';

const [, , oldVersionDir, newVersionDir, port] = process.argv;

if (!oldVersionDir || !newVersionDir || !port) {
console.error(
'Usage: node version-switching-server.js <oldVersionDir> <newVersionDir> <port>'
);
process.exit(1);
}

const server = await startVersionSwitchingServer({
oldVersionDirectory: oldVersionDir,
newVersionDirectory: newVersionDir,
port: parseInt(port, 10),
});

server.switchToNewVersion();
console.log('Version switching server started');
21 changes: 0 additions & 21 deletions packages/playground/website/playwright/version-switching-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,24 +73,3 @@ export async function startVersionSwitchingServer({
},
};
}

// @ts-ignore
if (import.meta.url === import.meta.resolve(process.argv[1])) {
const [, , oldVersionDir, newVersionDir, port] = process.argv;

if (!oldVersionDir || !newVersionDir || !port) {
console.error(
'Usage: node version-switching-server.js <oldVersionDir> <newVersionDir> <port>'
);
process.exit(1);
}

const server = await startVersionSwitchingServer({
oldVersionDirectory: oldVersionDir,
newVersionDirectory: newVersionDir,
port: parseInt(port, 10),
});

server.switchToNewVersion();
console.log('Version switching server started');
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ export function EnsurePlaygroundSiteIsSelected({
);

useEffect(() => {
opfsSiteStorage?.list().then(
if (!opfsSiteStorage) {
logger.error('Error loading sites: OPFS not available');
dispatch(siteListingLoaded([]));
return;
}
opfsSiteStorage.list().then(
(sites) => dispatch(siteListingLoaded(sites)),
(error) => {
logger.error('Error loading sites:', error);
Expand Down

0 comments on commit 4e0ef74

Please sign in to comment.