make_clickable(): Support URL with a closing parenthesis before a media/file extension

[hellofromtonya]

Tests: make_clickable() tests: Adds datasets for URLs with () within the path and with extensions.

A real world example image:
https://en.wikipedia.org/wiki/HMS_Ark_Royal_(91)#/media/File:HMS_Ark_Royal_(91)_just_after_launching.jpg

make_clickable(): Support URL with a closing parenthesis before a media/file extension.

Patch https://core.trac.wordpress.org/attachment/ticket/62037/62037-2.patch

Co-authored-by: PARTHVATALIYA parthvataliya@git.wordpress.org

Trac ticket: https://core.trac.wordpress.org/ticket/62037

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hellofromtonya, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[hellofromtonya]

Suggested change

	if ( isset( $matches[4] ) && ! empty( $matches[4] ) ) {
	if ( ! empty( $matches[4] ) ) {

empty() also checks if the element is exists.

[peterwilsoncc]

This looks good to me and tests well using the playground link.

I'll push up a change to the comment.

[peterwilsoncc]

Hmm, the tests started failing after merging in trunk and making the whitespace change to the comments. As this is a bug, I'll leave it for post beta 1.

[peterwilsoncc]

Failures are unrelated, committing.

[peterwilsoncc]

Merged r59143 / 9b6c034