Fix relative URLs for inlined stylesheets #1752
Conversation
|
It works like a charm. I tested with the block tutorial from the Block Editor Handbook by running:
Styles from the plugin: They get correctly adjusted when inlined on frontend: |
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
|
Changes landed with https://core.trac.wordpress.org/changeset/52036. |
| * @return string The CSS with URLs made relative to the WordPress installation. | ||
| */ | ||
| function _wp_normalize_relative_css_links( $css, $stylesheet_url ) { | ||
| $has_src_results = preg_match_all( '#url\s*\(\s*[\'"]?\s*([^\'"\)]+)#', $css, $src_results ); |
There was a problem hiding this comment.
Just curious: is there any reason why preg_replace_callback() wasn't used here? If it was, then it could eliminate the last str_replace() in the foreach loop. I've just opened a ticket and patch which shows the performance of this function can be improved >2x: https://core.trac.wordpress.org/ticket/58069
There was a problem hiding this comment.
PR to make this change: #4297
There was a problem hiding this comment.
There's no particular reason... I think at the time, it just didn't cross my mind to use preg_replace_callback() 👍
When styles get inlined, relative URLs break.
The problem is that URLs inside CSS files are relative to the stylesheet's path, and when styles get inlined that relation is lost.
This PR fixes the issue by finding relative URLs which then get modified to be relative to the site's root.
Trac ticket: https://core.trac.wordpress.org/ticket/54243
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.