This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Don't inline style.css, but enqueue it. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Nov 4, 2021
|
It depends. Perhaps wait until there is CSS that needs to be added? |
jffng
approved these changes
Nov 5, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Register and enqueue style.css without printing it inline.
Right now, the style.css file isn't actually used, it is empty. It was enqueued this way to allow adding CSS to the front,
for #206 and any other CSS we are not sure will be solved by theme.json in time.
Testing Instructions