Fix default null values and NULL value update edge case #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
force-pushed
the
fix/default-and-not-null-edge-cases
branch
from
2d9bf95
to
99b0c6c
Compare
bgrgicak
commented
Apr 15, 2024
Comment on lines
1139
to
1143
| if ('text' === $field->sqlite_data_type) { | ||
| $definition .= ' DEFAULT \'\''; | ||
| } else { | ||
| $definition .= ' DEFAULT 0'; | ||
| } |
There was a problem hiding this comment.
@adamziel what do you think about this solution?
Instead of rewriting update queries with COALESCE we could always set a default.
There was a problem hiding this comment.
This will allow both inserting NULL values and updating existing rows to NULL values. MySQL rejects inserting NULL values and only allows updating. I think it's fine for now, let's just create a new issue to track rejecting inserts in the future.
|
This PR should fix an issue with WPDB support where WordPress updates meta_value to |
bgrgicak
commented
Apr 15, 2024
|
Released v2.1.9 with this patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows SQL to set
DEFAULT NULLwhich currently isn't supported because the code is built asDEFAULT(empty value instead of NULL).It also adds support for updating a field to
NULLthat isNOT NULLand doesn't have aDEFAULTvalue.The result of the update should be an empty value ('' for text and 0 for numbers).
Testing instructions