-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the breadcrumb as the draggable handle #8764
Closed
Closed
Commits on Aug 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for add68b9 - Browse repository at this point
Copy the full SHA add68b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f6fa7 - Browse repository at this point
Copy the full SHA d4f6fa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d06670f - Browse repository at this point
Copy the full SHA d06670fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c119acb - Browse repository at this point
Copy the full SHA c119acbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32a465f - Browse repository at this point
Copy the full SHA 32a465fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f17ea - Browse repository at this point
Copy the full SHA 97f17eaView commit details -
Dont make the handle ever visible.
The drag handle no longer overlaps the block content div, so we can't render a placeholder in the handle itself. We need to figure somethingelse out.
Configuration menu - View commit details
-
Copy full SHA for 9c694b6 - Browse repository at this point
Copy the full SHA 9c694b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 123d37b - Browse repository at this point
Copy the full SHA 123d37bView commit details -
HACK: PoC to improve the draggable indicator
This tweaks the dashicon viewBox to render a not too embarrasing draggable indicator. This needs fixing.
Configuration menu - View commit details
-
Copy full SHA for a37bcde - Browse repository at this point
Copy the full SHA a37bcdeView commit details -
Use opacity to communicate what block is being dragged.
Previous to this refactor, it used to be a div inside the block wrapper that would become visible when the block was being dragged. That div would appear as grey. By refactoring the drag handler to the breadcrumb we no longer have that div, so we seek to use a different technique to communicate the same behavior. I also think is nicer to show the original content.
Configuration menu - View commit details
-
Copy full SHA for fcd43b7 - Browse repository at this point
Copy the full SHA fcd43b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebfe05a - Browse repository at this point
Copy the full SHA ebfe05aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3dbf6 - Browse repository at this point
Copy the full SHA ca3dbf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cea178 - Browse repository at this point
Copy the full SHA 4cea178View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47f02fe - Browse repository at this point
Copy the full SHA 47f02feView commit details -
it's only used internally by the block-list component.
Configuration menu - View commit details
-
Copy full SHA for 74d1b9c - Browse repository at this point
Copy the full SHA 74d1b9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f7ef1 - Browse repository at this point
Copy the full SHA 77f7ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26ca9bf - Browse repository at this point
Copy the full SHA 26ca9bfView commit details -
withDraggable injects initDragging instead of onDragStart
The new name clarifies the purpose and allows the original component to have passed the onDragStart property by some parent component.
Configuration menu - View commit details
-
Copy full SHA for ac43bb3 - Browse repository at this point
Copy the full SHA ac43bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c37b06 - Browse repository at this point
Copy the full SHA 7c37b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d4793a - Browse repository at this point
Copy the full SHA 9d4793aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9999a4f - Browse repository at this point
Copy the full SHA 9999a4fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.